RFR: 8343941: IGV: dump graph at different register allocation steps [v3]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Wed Nov 13 08:42:10 UTC 2024
On Tue, 12 Nov 2024 12:14:37 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>>> Just an idea, since you've provided a nice description for each phase in the PR description, should we add these in phasetype.hpp at the phases?
>>
>> I tried this out but could not find a good way to interleave code comments and `flags` entries (only using multi-line comments with additional backslashes, which looks too convoluted in my opinion).
>
>> > Just an idea, since you've provided a nice description for each phase in the PR description, should we add these in phasetype.hpp at the phases?
>>
>> I tried this out but could not find a good way to interleave code comments and `flags` entries (only using multi-line comments with additional backslashes, which looks too convoluted in my opinion).
>
> I see, that does not seem to be straight forward. I guess then it's okay to omit these descriptions.
Thanks Daniel, Christian, and Damon for reviewing! @chhagedorn may I get a re-approval?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22017#issuecomment-2472841322
More information about the hotspot-compiler-dev
mailing list