RFR: 8343148: C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method [v7]

[theoweidmannoracle]

On Mon, 11 Nov 2024 10:19:10 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cover another case
>
> src/hotspot/share/opto/loopTransform.cpp line 2054:
> 
>> 2052:   Node *newcle = old_new[loop_end->_idx];
>> 2053:   _igvn.hash_delete(newcle);
>> 2054:   Node *one = intcon(1);
> 
> While at it, you can also fix the wrong `*` placement (should be at type):
> Suggestion:
> 
>   Node* one = intcon(1);

Thanks, Christian, I have now configured my idea to take care of fixing the formatting of changed lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21836#discussion_r1839911939