RFR: 8342047: Create Template Assertion Predicates with Halt nodes only instead of uncommon traps [v2]

[Christian Hagedorn]

On Wed, 13 Nov 2024 10:22:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/opto/loopPredicate.cpp
>>   
>>   Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>
> src/hotspot/share/opto/loopPredicate.cpp line 314:
> 
>> 312:          template_assertion_predicate_success_proj->has_out(j);
>> 313:          j++) {
>> 314:       Node* fast_node = template_assertion_predicate_success_proj->out(j);
> 
> Suggestion:
> 
>       Node* true_path_node = template_assertion_predicate_success_proj->out(j);
> 
> Now that you have renamed it `fast_proj` -> `true_path_loop_proj`.
> And why `true_path_loop_proj` and not just `true_path_proj`?

Good catch. I think `true_path_loop_node` would be the most accurate. I'd prefer to have "loop" in the name since `true_path` on its own could be a true path of any If node (though it could be inferred from the context).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22040#discussion_r1840141259