RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v25]

Quan Anh Mai qamai at openjdk.org
Wed Nov 13 13:48:59 UTC 2024


On Mon, 4 Nov 2024 12:41:58 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/type.hpp line 622:
>> 
>>> 620:  * TypeInt lie in the intervals [_lo, jint(_uhi)] or [jint(_ulo), _hi]
>>> 621:  *
>>> 622:  * Proof: For 2 jint value x, y such that they are both >= 0 or < 0. Then:
>> 
>> Suggestion:
>> 
>>  * Proof: For 2 jint value x, y such that they are both >= 0 or both < 0. Then:
>> 
>> Or are you allowing them to one be positive and one negative?
>
> Also: this is more of a "Lemma", and could be stated before the "Proof" of you property 2... it is property 2 that you are trying to prove here, right? The indentation would help for that as well.

Yes I have changed it to lemma and done some indentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1840308577


More information about the hotspot-compiler-dev mailing list