RFR: 8340453: C2: Improve encoding of LoadNKlass for compact headers [v2]
Roman Kennke
rkennke at openjdk.org
Wed Nov 13 19:45:36 UTC 2024
> We currently use the offset 4 as a placeholder in LoadNKlass, when running with compact headers. In reality, we are loading from offset 0, but we want to keep LoadNKlass on a separate memory slice from other mark-word-accesses, because LoadNKlass is essentially immutable memory. The consequence is that we need to figure out the address of the mark-word in the backend, and this is ugly.
>
> However, we can do better. We can just as well load 4 bytes from offset 4, and shift by a 32 smaller shift. This has previously not been possible because we needed to check for the monitor bit in the markWord, but this is no longer necessary. This simplifies the code and even makes the instructions encoding a bit smaller.
>
> Testing:
> - [x] tier1 aarch64 +UCOH
> - [x] tier1 x86_64 +UCOH
Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
Improve opto asm of LoadNKlass
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22078/files
- new: https://git.openjdk.org/jdk/pull/22078/files/4b734742..d2010d1e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22078&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22078&range=00-01
Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/22078.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22078/head:pull/22078
PR: https://git.openjdk.org/jdk/pull/22078
More information about the hotspot-compiler-dev
mailing list