RFR: 8344122: IGV: Extend c2 IdealGraphPrinter to send subgraphs to IGV [v4]

[Tobias Holenstein]

On Thu, 14 Nov 2024 12:27:47 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   create Compile::init_igv()
>
> src/hotspot/share/opto/node.cpp line 2054:
> 
>> 2052:     if (_print_igv) {
>> 2053:       Compile* C = Compile::current();
>> 2054:       if (C->should_print_igv(0)) {
> 
> I guess the reason to call `should_print_igv` here is to initialize `Compile::_igv_printer` if necessary. Would it be possible to factor out the initialization part https://github.com/openjdk/jdk/blob/2145ace384137b1c028a68dc34a8800577c7a43e/src/hotspot/share/opto/compile.cpp#L5214-L5217 into a separate function that only checks if `_igv_printer` is `nullptr` and, if so, initializes it, and only call that function from here?

sure. done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22076#discussion_r1842433726