RFR: 8319850: PrintInlining should print which methods are late inlines [v3]

[theoweidmannoracle]

On Fri, 15 Nov 2024 03:08:38 GMT, Dean Long <dlong at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test
>
> src/hotspot/share/opto/compile.cpp line 4490:
> 
>> 4488: 
>> 4489:     _print_inlining_list->at_put(_print_inlining_idx, buffer);
>> 4490:     print_inlining_reset();
> 
> Reset seems out of place here.  We already checked it was empty when we called print_inlining_assert_ready(), and we never printed to that buffer.  Maybe this is left over from before the print_inlining_inner_message() refactor?

I think you are right and reset can be removed now. An earlier version was using the internal buffer, which made this call necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1843290511