RFR: 8326369: Add test to verify bimorphic inlining happens after morphism changes [v5]

Emanuel Peter epeter at openjdk.org
Fri Nov 15 07:37:50 UTC 2024


On Thu, 14 Nov 2024 14:36:16 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> This issue was fixed by JDK-8339299 indirectly (see [PR](https://github.com/openjdk/jdk/pull/20786)), but the PR for 8339299 didn't include any new tests, so I'm sending this PR with the test that Filipp added in 8326369 so that such issue doesn't come back inadvertently. I've added him as co-author and applied some small formatting changes.
>
> Galder Zamarreño has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into topic.bimorphic-inlining
>  - Update test/hotspot/jtreg/compiler/inlining/InlineBimorphicVirtualCallAfterMorphismChanged.java
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>  - Added Jetbrains copyright
>  - Added copyright and @bug identifiers
>  - Fix formatting
>  - Fix more formatting issues
>  - Fix formatting
>  - Add test that replicates issue
>    
>    Co-authored-by:  Filipp Zhinkin <fzhinkin at openjdk.org>

Looks good to me :)

-------------

Marked as reviewed by epeter (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21920#pullrequestreview-2437866731


More information about the hotspot-compiler-dev mailing list