RFR: 8344205: [PPC]: failing assertion: sharedRuntime_ppc.cpp:1652: cookie not found

Fri Nov 15 07:54:51 UTC 2024

On Thu, 14 Nov 2024 15:29:02 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This PR removes the bad assertion that fails when leaving a continuation because the cookie value is not found in `frame::common_abi::cr`.
> This is because after the cookie is stored there when entering the continuation it is overridden by the runtime call to thaw frames. This is compliant with the abi.
> Strangely the assertion only ever failed on aix.
> 
> Testing: compiler/codecache/stress/UnexpectedDeoptimizationTest.java always failed since the bad assertion was introduced recently. It succeeds after removal.
> 
> The fix passed our CI testing:
> Tier 1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
> Testing was done on the main platforms and also on Linux/PPC64le and AIX.

The [macos-x64 test failure](https://github.com/reinrich/jdk/actions/runs/11840204418/job/32996332320#step:9:6280) is unrelated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22109#issuecomment-2478157048