RFR: 8344204: IGV: Button to enable/disable cutting of long edges
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Fri Nov 15 11:22:19 UTC 2024
On Thu, 14 Nov 2024 14:51:00 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
> Currently IGV layout cuts edges that are longer than 10 layers. Add an option to enable/disable the cutting
>
> <img width="148" alt="cut" src="https://github.com/user-attachments/assets/0a9bf571-71b6-4c99-9954-63b896b3f769">
>
> Because the Toolbar gets crowded, I removed the non-functioning button for `HideDuplicatesAction`
Looks good, thanks for doing this! Edge cutting does more harm than good in most cases IMO (especially in the CFG view), so agree with disabling it by default.
Please remove the leftover icon `hideDuplicates.png`.
src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/CutEdgesAction.java line 2:
> 1: /*
> 2: * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22108#pullrequestreview-2438289243
PR Review Comment: https://git.openjdk.org/jdk/pull/22108#discussion_r1843589441
More information about the hotspot-compiler-dev
mailing list