RFR: 8343148: C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method [v10]

theoweidmannoracle duke at openjdk.org
Fri Nov 15 14:30:14 UTC 2024


> This patch introduces the methods `PhaseIdealLoop::intcon` and `PhaseIdealLoop::longcon` which are wrappers for:
> 
> 
> ConINode* node = _igvn.intcon(i);
> set_ctrl(node, C->root());
> 
> 
> and
> 
> 
> ConLNode* node = _igvn.longcon(i);
> set_ctrl(node, C->root());
> 
> 
> Occurrences of this pattern in loopnode.cpp were replaced with the appropriate call to the new methods.

theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:

  Replace set_root_as_ctrl with assert

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21836/files
  - new: https://git.openjdk.org/jdk/pull/21836/files/48ab32f8..44eaf101

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21836&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21836&range=08-09

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/21836.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21836/head:pull/21836

PR: https://git.openjdk.org/jdk/pull/21836


More information about the hotspot-compiler-dev mailing list