RFR: 8343148: C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method [v10]

[theoweidmannoracle]

On Fri, 15 Nov 2024 15:02:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace set_root_as_ctrl with assert
>
> src/hotspot/share/opto/loopopts.cpp line 192:
> 
>> 190: 
>> 191:     if (x->is_Con()) {
>> 192:       assert(get_ctrl(x) == C->root(), "constant control is not root");
> 
> I think we should still execute `continue` here because we want to skip constants. Otherwise, the updates look good!

Oops, that slipped through. Thanks! I fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21836#discussion_r1843966763