RFR: 8343148: C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method [v12]
Christian Hagedorn
chagedorn at openjdk.org
Mon Nov 18 08:40:43 UTC 2024
On Mon, 18 Nov 2024 07:56:31 GMT, theoweidmannoracle <duke at openjdk.org> wrote:
>> This patch introduces the methods `PhaseIdealLoop::intcon` and `PhaseIdealLoop::longcon` which are wrappers for:
>>
>>
>> ConINode* node = _igvn.intcon(i);
>> set_ctrl(node, C->root());
>>
>>
>> and
>>
>>
>> ConLNode* node = _igvn.longcon(i);
>> set_ctrl(node, C->root());
>>
>>
>> Occurrences of this pattern in loopnode.cpp were replaced with the appropriate call to the new methods.
>
> theoweidmannoracle has updated the pull request incrementally with three additional commits since the last revision:
>
> - Update src/hotspot/share/opto/loopnode.cpp
>
> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
> - Update src/hotspot/share/opto/loopnode.cpp
>
> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
> - Update src/hotspot/share/opto/loopnode.cpp
>
> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
Marked as reviewed by chagedorn (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21836#pullrequestreview-2441861659
More information about the hotspot-compiler-dev
mailing list