RFR: 8340453: C2: Improve encoding of LoadNKlass for compact headers [v4]
Martin Doerr
mdoerr at openjdk.org
Mon Nov 18 10:16:02 UTC 2024
On Thu, 14 Nov 2024 11:32:47 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> We currently use the offset 4 as a placeholder in LoadNKlass, when running with compact headers. In reality, we are loading from offset 0, but we want to keep LoadNKlass on a separate memory slice from other mark-word-accesses, because LoadNKlass is essentially immutable memory. The consequence is that we need to figure out the address of the mark-word in the backend, and this is ugly.
>>
>> However, we can do better. We can just as well load 4 bytes from offset 4, and shift by a 32 smaller shift. This has previously not been possible because we needed to check for the monitor bit in the markWord, but this is no longer necessary. This simplifies the code and even makes the instructions encoding a bit smaller.
>>
>> Testing:
>> - [x] tier1 aarch64 +UCOH
>> - [x] tier1 x86_64 +UCOH
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>
> Add missing newline in opto output
AIX on PPC64 and linux on s390 are supported Big Endian platforms. We can't do the same change for these platforms without endianness sensitive adaptations.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22078#issuecomment-2482535428
More information about the hotspot-compiler-dev
mailing list