RFR: 8344371: RISC-V: compiler/intrinsics/chacha/TestChaCha20.java fails after JDK-8343555

Hamlin Li mli at openjdk.org
Mon Nov 18 11:47:56 UTC 2024


On Mon, 18 Nov 2024 01:16:37 GMT, Fei Yang <fyang at openjdk.org> wrote:

> From the error message, the cause of the failure is that 'UseRVV' was made diagnostic in [JDK-8343555](https://bugs.openjdk.org/browse/JDK-8343555). But the test was not updated to refect this. Instead of adding one extra `-XX:+UnlockDiagnosticVMOptions` option, this simply removed the use of `-XX:+UseRVV` from the test. The reason is that we have `-XX:+UseRVV` auto detected and enabled, so we will have RVV extension if we satisfy the test requirement:
> 
> (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*")
> 
> 
> Same test pass with this fix on linux-riscv64 with RVV extension.

Looks good. Thanks for catching this.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22188#pullrequestreview-2442392962


More information about the hotspot-compiler-dev mailing list