RFR: 8344026: [s390x] ubsan failure: signed integer overflow in c1_LIRGenerator_s390.cpp [v2]

Kim Barrett kbarrett at openjdk.org
Tue Nov 19 05:35:50 UTC 2024


On Tue, 19 Nov 2024 04:44:00 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR adds `c > 0 && c < max_jint` check in c1_LIRGenerator_s390.cpp. Please look JBS for more info.
>
> Amit Kumar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - s390x update
>  - ppc changes

It looks to me that aarch64 and arm have exactly the same issue.  As mentioned in JBS, x86 and riscv already have similar
checking as being proposed here.  It would be nice if all platforms had exactly the same check, rather than some in one
order and some in a different order.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22144#issuecomment-2484744881


More information about the hotspot-compiler-dev mailing list