RFR: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize
Andrew Haley
aph at openjdk.org
Tue Nov 19 07:29:55 UTC 2024
On Sun, 17 Nov 2024 09:06:37 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi all,
> Currently on aarch64 platform the debug VM option `-XX:+VerifyActivationFrameSize` is Unimplemented. I want to implement `-XX:+VerifyActivationFrameSize` to make JVM easier to diagnose. Only effect debug build plus with option `-XX:+VerifyActivationFrameSize`, the change has been verified locally, the risk is low.
>
> Additional testing
>
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 release build
> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 fastdebug build
src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 397:
> 395: if (VerifyActivationFrameSize) {
> 396: Label L;
> 397: subw(rscratch1, rfp, esp);
Use 64-bit arithmetic here, or you'll miss some kinds of error.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22181#discussion_r1846712858
More information about the hotspot-compiler-dev
mailing list