RFR: 8334431: C2 SuperWord: fix performance regression due to store-to-load-forwarding failures [v3]

Emanuel Peter epeter at openjdk.org
Tue Nov 19 15:07:34 UTC 2024


On Tue, 19 Nov 2024 14:50:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use constant method handle to make the benchmark smaller
>
> test/hotspot/jtreg/compiler/loopopts/superword/TestCyclicDependency.java line 36:
> 
>> 34:  *                   TestCyclicDependency
>> 35:  * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -XX:+AlignVector -XX:+VerifyAlignVector
>> 36:  *                   TestCyclicDependency
> 
> These flags will be ignored for the test VM. You should pass them as separate runs in `main()` with `TestFramework.runWithFlags()`.

Oh, is that true? That's scarry. I'm sure we are doing this elsewhere too. Is there not a way to forward these kinds of flags from the `@run` to the IR Framework test VM?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21521#discussion_r1848531873


More information about the hotspot-compiler-dev mailing list