RFR: 8334431: C2 SuperWord: fix performance regression due to store-to-load-forwarding failures [v5]

Emanuel Peter epeter at openjdk.org
Tue Nov 19 16:03:26 UTC 2024


On Tue, 19 Nov 2024 15:37:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/vm/compiler/VectorStoreToLoadForwarding.java line 91:
>> 
>>> 89:     }
>>> 90: 
>>> 91:     @CompilerControl(CompilerControl.Mode.DONT_INLINE)
>> 
>> Err are you sure this works I think this should be `FORCE_INLINE` instead. I see you want to have different `SIZE`s, too. Then you can make a `MutableCallSite` for each parameter. The magic here is that the compiler will treat the call target as a constant and force a recompilation each time you call `setTarget`
>
> Hmm, somehow it looked like it worked... but it cannot with this. I'll have another look.

I don't need different sizes though. Just the OFFSET is ok - those really need to be constant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21521#discussion_r1848633084


More information about the hotspot-compiler-dev mailing list