RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize [v2]
SendaoYan
syan at openjdk.org
Wed Nov 20 05:00:29 UTC 2024
On Wed, 20 Nov 2024 04:57:39 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> Currently on linux-riscv64 platform the debug VM option `-XX:+VerifyActivationFrameSize` is Unimplemented. I want to implement `-XX:+VerifyActivationFrameSize` to make JVM easier to diagnose. Only effect debug build plus with option `-XX:+VerifyActivationFrameSize`, the change has been verified locally, the risk is low.
>>
>> Additional testing
>>
>> - [ ] jtreg tests(include tier1/2/3 etc.) on linux-riscv64 release build
>> - [ ] Run SPECjbb2015 with -XX:+VerifyActivationFrameSize
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> Exclude 2 frame metadata words before compare to min_frame_size
Thanks, I found that `sp -esp` equals 96, larger than `min_frame_size` 16. I think the extra 16 bytes is the `2 frame metadata words`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22264#discussion_r1849530410
More information about the hotspot-compiler-dev
mailing list