RFR: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize [v4]
Hamlin Li
mli at openjdk.org
Wed Nov 20 13:22:21 UTC 2024
On Wed, 20 Nov 2024 12:52:39 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> Currently on linux-riscv64 platform the debug VM option `-XX:+VerifyActivationFrameSize` is Unimplemented. I want to implement `-XX:+VerifyActivationFrameSize` to make JVM easier to diagnose. Only effect debug build plus with option `-XX:+VerifyActivationFrameSize`, the change has been verified locally, the risk is low.
>>
>> Additional testing
>>
>> - [x] Run SPECjbb2015 with -XX:+VerifyActivationFrameSize option
>
> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>
> - delete comment "// Exclude 2 frame metadata words"
> - Avoid calculate the compare value in the generated code
Looks good, Thanks!
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22264#pullrequestreview-2448599976
More information about the hotspot-compiler-dev
mailing list