RFR: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
Richard Reingruber
rrich at openjdk.org
Wed Nov 20 14:40:18 UTC 2024
On Wed, 20 Nov 2024 10:36:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> Nice analysis! The fix looks reasonable to me but I'm a bit worried that such removals of ResourceMarks will lead to an increase in peak memory consumption because memory is only released much later now. And I would assume there is a reason for the ResourceMark placement, i.e., below code doing significant temporary allocations. Kind of related: [JDK-8337015](https://bugs.openjdk.org/browse/JDK-8337015).
I was also worried about increased memory consumption. There's at least the minimal testing I'm reporting about in the pr synopsis. Do you know about work loads that lead to higher memory consumption? Maybe you've got some internal tests. For that purpose I put the trace code into the pr. Should be easy to use.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22200#issuecomment-2488755471
More information about the hotspot-compiler-dev
mailing list