RFR: 8340010: Fix vectorization tests with compact headers

Hamlin Li mli at openjdk.org
Thu Nov 21 11:17:21 UTC 2024


On Thu, 21 Nov 2024 10:28:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java line 184:
>> 
>>> 182:     @IR(counts = { IRNode.LOAD_VECTOR_L, ">=1", IRNode.STORE_VECTOR, ">=1" },
>>> 183:         // This test fails with compact headers, but only with UseSSE<=3.
>>> 184:         applyIf = { "UseCompactObjectHeaders", "false" },
>> 
>> Is this removed intentiionally? or it should be `applyIfOr = {"UseCompactObjectHeaders", "false", "AlignVector", "false"},`?
>
> Well, it turns out that this case always vectorizes. Did you see the comments below? It is a strange exception, because this test manually sets a large "base-to-payload-offset" of 64.

Ah, it makes sense to me, sorry I did not read the code below carefully.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22199#discussion_r1851860890


More information about the hotspot-compiler-dev mailing list