RFR: 8319850: PrintInlining should print which methods are late inlines [v11]

theoweidmannoracle duke at openjdk.org
Fri Nov 22 08:44:26 UTC 2024


On Thu, 21 Nov 2024 17:24:43 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix more style issues
>
> src/hotspot/share/opto/printinlining.hpp line 51:
> 
>> 49:    * @returns An output stream which stores the message associated with this attempt. The buffer stays valid until InlinePrinter is deallocated.
>> 50:    *          You can print arbitrary information to this stream but do not add line breaks, as this will break formatting.
>> 51:    */
> 
> Style: We typically don't use `@param`, `@returns` in Hotspot.
> 
> Consider this a nit, I'm not familiar enough with C2 codebase to know whether this adheres to C2 style.

I will change this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1853503849


More information about the hotspot-compiler-dev mailing list