RFR: 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails

Doug Simon dnsimon at openjdk.org
Sat Nov 23 15:50:16 UTC 2024


On Fri, 22 Nov 2024 20:53:55 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This PR prevents a rare, intermittent failure of TestEnableJVMCIProduct.java.
>> It does this by writing the expected test output to a file instead of stdout to avoid issues with VM error logging interleaving with the test output.
>
> test/hotspot/jtreg/compiler/jvmci/TestEnableJVMCIProduct.java line 106:
> 
>> 104:                 }
>> 105:             } else if (flag.equals("-XX:+UseGraalJIT")) {
>> 106:                 output.shouldContain("jvmci.Compiler=graal");
> 
> Does changing shouldContain() to stdoutShouldContain() also solve the problem?

I don't think so as the output is sent to HotSpot's log stream (i.e. `tty`) which I believe goes stdout by default.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22323#discussion_r1855215437


More information about the hotspot-compiler-dev mailing list