RFR: 8319850: PrintInlining should print which methods are late inlines [v14]

theoweidmannoracle duke at openjdk.org
Mon Nov 25 08:28:18 UTC 2024


On Sat, 23 Nov 2024 00:12:02 GMT, Dean Long <dlong at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix TestDuplicatedLateInliningOutput
>
> src/hotspot/share/opto/compile.cpp line 675:
> 
>> 673:       _oom(false),
>> 674:       _replay_inline_data(nullptr),
>> 675:       _inline_printer(comp_arena(), directive->PrintInliningOption || PrintOptoInlining),
> 
> How do we support print_intrinsics()?

That's a good point. Inline printer should be enabled if C->print_intrinsics() or C->print_inlining() is true so this change does seem to change the behavior. I'll fix this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1856092003


More information about the hotspot-compiler-dev mailing list