RFR: 8319850: PrintInlining should print which methods are late inlines [v14]

[theoweidmannoracle]

On Sat, 23 Nov 2024 00:19:13 GMT, Dean Long <dlong at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix TestDuplicatedLateInliningOutput
>
> src/hotspot/share/opto/callGenerator.cpp line 422:
> 
>> 420: 
>> 421:   if (cg != nullptr) {
>> 422:     if (!allow_inline) {
> 
> Is `!allow_inline` really the correct check here and in LateInlineVirtualCallGenerator::do_late_inline_check()?  This is where I ran into trouble with the asserts in previous implementation.  Note that even if allow_inline is passed as true to the CallGenerator factory, the factory can force it to false for a variety of reasons.  Maybe we should be looking at what kind of CallGenerator we have in `cg`?

With the new implementation it is always safe to call C->inline_printer()->record. In case inline printing is disabled, it is just a no-op. Also allow_inline seems to be coming from C->inlining_incrementally(). Is your concern that we might miss to print something? Or that we print something extra that is not true?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1856293304