RFR: 8319850: PrintInlining should print which methods are late inlines [v17]

theoweidmannoracle duke at openjdk.org
Mon Nov 25 11:35:19 UTC 2024


> In https://github.com/openjdk/jdk/pull/16595 @caojoshua previously suggested changes to indicate which calls were inlined late, when printing inlines. This PR re-introduces the changes from the previously closed PR and fixes a minor issue where asserts were triggered.
> 
> Concerns were raised by @rwestrel in the previous PR:
> 
>> When InlineTree::ok_to_inline() is called, some diagnostic message is recorded for the call site. Do I understand right that with this patch, if the call is inlined late, then that message is dropped and replaced by a new "late inline.." message? If that's the case, isn't it the case that sometimes the InlineTree::ok_to_inline() has some useful information that's lost when late inlining happens?
> 
> As already pointed out in the PR by @caojoshua, this does not matter for string/methodhandle/vector/boxing late inlines, as they are [only performed if ok_to_inline() returns true](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/doCall.cpp#L189). This is also the only call to ok_to_inline().  
> 
> The only other location, where late inline call generators are created, are calls to CallGenerator::for_late_inline_virtual(), which creates a LateInlineVirtualCallGenerator. LateInlineVirtualCallGenerator (introduced in https://github.com/openjdk/jdk/pull/1550) does not really perform inlining but rather performs strength reduction from virtual to static calls. As can be verified by running the according test `test/hotspot/jtreg/compiler/c2/irTests/TestPostParseCallDevirtualization.java`, this does not affect the printing for inlining:
> 
> 
> 5022 1026       3       compiler.c2.irTests.TestPostParseCallDevirtualization::callHelper (7 bytes)   made not entrant
>                               @ 1   compiler.c2.irTests.TestPostParseCallDevirtualization$I::method (0 bytes)   failed to inline: virtual call
> 
> 
> Thus, as far as I can tell, the proposed changes by @caojoshua do not lose any useful information about why no inlining prior to the late inlining occurred.

theoweidmannoracle has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:

 - Merge branch 'master' into 8319850
 - Change comment style
 - Change is_enabled to old pattern
 - Fix TestDuplicatedLateInliningOutput
 - Fix BCI -1
 - Style changes
 - Fix more style issues
 - Undo accidental style changes
 - Add another missing header
 - Add precompiled header
 - ... and 12 more: https://git.openjdk.org/jdk/compare/5cbe63f3...5114d189

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21899/files
  - new: https://git.openjdk.org/jdk/pull/21899/files/86bd2476..5114d189

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21899&range=16
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21899&range=15-16

  Stats: 345845 lines in 4863 files changed: 182635 ins; 129472 del; 33738 mod
  Patch: https://git.openjdk.org/jdk/pull/21899.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21899/head:pull/21899

PR: https://git.openjdk.org/jdk/pull/21899


More information about the hotspot-compiler-dev mailing list