RFR: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_<arch>.cpp file [v7]

Andrew Haley aph at openjdk.org
Mon Nov 25 13:39:32 UTC 2024


On Fri, 22 Nov 2024 16:53:34 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR converts datatype from `jint` to `juint` for contstant `c` check in c1_LIRGenerator_<arch>.cpp. Please look JBS for more info.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert to c for -1 check

src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp line 280:

> 278: 
> 279: bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result, LIR_Opr tmp) {
> 280:   unsigned int u_value = (juint)c;

Keep the type names consistent.
Suggestion:

  juint u_value = (juint)c;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22144#discussion_r1856624821


More information about the hotspot-compiler-dev mailing list