RFR: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_<arch>.cpp file [v7]

[Andrew Haley]

On Mon, 25 Nov 2024 13:32:57 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert to c for -1 check
>
> src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp line 280:
> 
>> 278: 
>> 279: bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result, LIR_Opr tmp) {
>> 280:   unsigned int u_value = (juint)c;
> 
> Keep the type names consistent.
> Suggestion:
> 
>   juint u_value = (juint)c;

I think we're done now with this change. What are your plans to test the Arm 32-bit version?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22144#discussion_r1856630127