RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v3]
theoweidmannoracle
duke at openjdk.org
Mon Nov 25 14:19:17 UTC 2024
On Mon, 25 Nov 2024 13:28:50 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve tests, remove edge case
>
> src/hotspot/share/opto/divnode.cpp line 488:
>
>> 486:
>> 487: const Type* t = phase->type(div->in(2));
>> 488: if (t == TypeClass::ONE) { // Identity?
>
> You can move this into `l == 0 || l == 1` below.
This is also the same for ModI/LNode::Ideal. I think all of this code should be reviewed as part of an RFE and then changed together
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1856693101
More information about the hotspot-compiler-dev
mailing list