RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v3]
theoweidmannoracle
duke at openjdk.org
Mon Nov 25 14:23:17 UTC 2024
On Mon, 25 Nov 2024 14:16:50 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> This is analogous to code for ModI/LNode::Ideal.
>
> That may be true. But `uncast` would be still a good idea, so that we can see through `Cast` nodes. I think it could then also be added to `ModI/L`.
>
> @merykitty do you have an easy way to unit test this, i.e. to have a test with a Cast?
@eme64 I didn't mean to imply it's not useful. But I think it would be better to do these changes to the existing code for ModI/L and DivI/L in a separate RFE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1856698963
More information about the hotspot-compiler-dev
mailing list