RFR: 8344013: "bad tag in log" assert with +LogCompilation +CITimeVerbose [v2]

Sonia Zaldana Calles szaldana at openjdk.org
Mon Nov 25 15:36:00 UTC 2024


On Mon, 25 Nov 2024 07:25:29 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding regression test
>
> Looks good to me. Can you also add a regression test for it? Since this already triggers with `--version`, you can just create a hello world like test and run with the mentioned flags.
> 
> Just a side note:
> 
>> Note how the constructor adds the [phase tag](https://github.com/openjdk/jdk/blame/master/src/hotspot/share/opto/compile.cpp#L4327).
> 
> You can directly insert the permalink (in the non-blame view) such that the code is inlined in the PR for easier reading :-)
> 
> https://github.com/openjdk/jdk/blob/6f622da7fbae67d8c1cd9e795127adac58a246a9/src/hotspot/share/opto/compile.cpp#L4327

Thanks for the reviews @chhagedorn @dafedafe! I added a regression test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22331#issuecomment-2498343923


More information about the hotspot-compiler-dev mailing list