RFR: 8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract() [v2]

Doug Simon dnsimon at openjdk.org
Mon Nov 25 17:06:22 UTC 2024


On Mon, 25 Nov 2024 16:49:54 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> The `isArray() || !isAbstract()` idiom is often used in Graal for expressing if a type is concrete and can be instantiated. This PR overrides `ModifiersProvider.isConcrete` in `ResolvedJavaType` to provide this idiom.
>
> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comment.

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ModifiersProvider.java line 140:

> 138: 
> 139:     /**
> 140:      * Returns true if a method is with a real implementation, or if a type can

"if this element is a method with a concrete implementation, or a type that can be instantiated"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22111#discussion_r1856967686


More information about the hotspot-compiler-dev mailing list