RFR: 8344960: RISC-V: fix TestFloatConversionsVectorNaN for COH and AlignVector

Ludovic Henry luhenry at openjdk.org
Tue Nov 26 10:26:43 UTC 2024


On Mon, 25 Nov 2024 15:03:23 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this patch?
> Some background: COH change the header size of an object (from 12 to 8) when compress klass headers is on, this invalidate some of the alignment check in SLP, so the fix is to disable the IR checks when either UseCompactObjectHeaders or AlignVector is on.
> It's a follow-up of JDK-8343827 and JDK-8340010 on riscv.
> 
> Thanks

Marked as reviewed by luhenry (Committer).

test/hotspot/jtreg/compiler/vectorization/TestFloatConversionsVectorNaN.java line 53:

> 51: 
> 52:     public static void main(String args[]) {
> 53:         TestFramework framework = new TestFramework(TestFloatConversionsVectorNaN.class);

Is it more usual to take this approach or to call `TestFramework.runWithFlags` multiple times?

-------------

PR Review: https://git.openjdk.org/jdk/pull/22363#pullrequestreview-2461036952
PR Review Comment: https://git.openjdk.org/jdk/pull/22363#discussion_r1858212083


More information about the hotspot-compiler-dev mailing list