RFR: 8319850: PrintInlining should print which methods are late inlines [v14]
theoweidmannoracle
duke at openjdk.org
Tue Nov 26 14:13:02 UTC 2024
On Mon, 25 Nov 2024 22:33:21 GMT, Dean Long <dlong at openjdk.org> wrote:
>> With the new implementation it is always safe to call C->inline_printer()->record. In case inline printing is disabled, it is just a no-op. Also allow_inline seems to be coming from C->inlining_incrementally(). Is your concern that we might miss to print something? Or that we print something extra that is not true?
>
>> With the new implementation it is always safe to call C->inline_printer()->record. In case inline printing is disabled, it is just a no-op. Also allow_inline seems to be coming from C->inlining_incrementally(). Is your concern that we might miss to print something?
>
> Yes, that we might miss printing something when allow_inline was true.
I think I didn't change the logic behind when it would print now as compared to before my refactoring. I think investigating whether this is really the correct check is a bit beyond the scope about this PR. Should I file a RFE for this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21899#discussion_r1858604707
More information about the hotspot-compiler-dev
mailing list