RFR: 8344766: AES/CTR slow at big payloads [v2]

Anthony Scarpino ascarpino at openjdk.org
Wed Nov 27 15:42:38 UTC 2024


On Wed, 27 Nov 2024 15:25:02 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Not sure what about the comment needs to be updated. Maybe provide a suggestion?
>> 
>> Also, please have a look at the original issue, we had a similar discussion about this same comment and this was the result.
>
> I dont see any harm in adding descriptive comments giving good justification.
> 
> Here is my suggestion:-
> 
> "Change facilitate eager intrinsification due to OSR compilation, in addition safe point induced at loop back edge reduce time to safepoint before GC epoch."

I disagree with changing the comment. What @jatin-bhateja suggests, few will understand. The current comment describes what is being done in the simplest terms. 

Please leave the comment as is

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22300#discussion_r1860885254


More information about the hotspot-compiler-dev mailing list