RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v8]

theoweidmannoracle duke at openjdk.org
Thu Nov 28 16:15:58 UTC 2024


On Thu, 28 Nov 2024 14:30:45 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   abs(MIN_INT) is not positive
>
> test/hotspot/jtreg/compiler/c2/irTests/UDivINodeIdealizationTests.java line 88:
> 
>> 86: 
>> 87:     @Test
>> 88:     @IR(failOn = {IRNode.DIV})
> 
> All these should be `failOn = {IRNode.UDIV}`

Good catch, thanks! Fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1862447426


More information about the hotspot-compiler-dev mailing list