RFR: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes [v10]

theoweidmannoracle duke at openjdk.org
Thu Nov 28 16:37:22 UTC 2024


On Thu, 28 Nov 2024 16:16:42 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add UDIV
>
> test/hotspot/jtreg/compiler/c2/irTests/ModINodeIdealizationTests.java line 39:
> 
>> 37:  */
>> 38: public class ModINodeIdealizationTests {
>> 39:     public static final int RANDOM_POWER_OF_2 = 1 << (1 + new Random().nextInt(30));
> 
> We use `Utils.getRandomInstance()` so that tests can be replayed with the same seed.

Thanks for the tip! I was already wondering if something like this existed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22061#discussion_r1862470866


More information about the hotspot-compiler-dev mailing list