RFR: 8342677: Add IR validation tests for newly added saturated vector add / sub operations

[Emanuel Peter]

On Fri, 29 Nov 2024 06:28:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> This is a follow up PR to https://github.com/openjdk/jdk/pull/20507
>> It adds IR validation tests for newly added saturated vector add / sub operations.
>
> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 257:
> 
>> 255:     }
>> 256: 
>> 257:     public static final String SADD_VB = VECTOR_PREFIX + "SADD_VB" + POSTFIX;
> 
> Suggestion:
> 
>     public static final String SATURATING_ADD_VB = VECTOR_PREFIX + "SATURATING_ADD_VB" + POSTFIX;
> 
> I would prefer if this was written out.

Ah. Now I see that we also named it `VectorOperators.SADD`... hmm. Would have been nice to say what the `S` means here. I would always go with the longer, more explicit name (unless it is really very very long).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21603#discussion_r1863018535