RFR: 8345172: x86: Some CPU feature asserts are declared as 32-bit only [v2]

Aleksey Shipilev shade at openjdk.org
Fri Nov 29 15:07:37 UTC 2024


On Fri, 29 Nov 2024 14:56:40 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

> I happened to notice that for SSE2 most asserts are `NOT_LP64`

Right, that is because our x86_64 is baselined to have at least SSE2:
https://github.com/openjdk/jdk/blob/4da7c3548436ffffb009828891df0d13d47370e3/src/hotspot/cpu/x86/vm_version_x86.cpp#L896-L903

Therefore, checking for SSE <= 2 anywhere else in x86_64 is redundant, but harmless. I guess you need to remember this every time an assert is added, so some leakage happens every so often. I can wrap the currently exposed sse1/2 checks in `NOT_LP64`, if you want.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22432#issuecomment-2507997403


More information about the hotspot-compiler-dev mailing list