RFR: 8345039: IGV: save user-defined node colors to XML

[Tobias Holenstein]

On Fri, 29 Nov 2024 08:50:26 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This PR depends on https://github.com/openjdk/jdk/pull/22402 
>> 
>> [JDK-8343535](https://bugs.openjdk.org/browse/JDK-8343535) introduced the possibility to give user-defined colors to a node.
>> The colors are lost when the user goes to the next graph or when IGV is closed. Save the colors as a property of the graph to the XML to make it more permanent. This requires that the user can also remove the colors again.
>> 
>> <img width="474" alt="color" src="https://github.com/user-attachments/assets/c994f93c-7db1-40e6-9963-2f5417cec77f">
>> 
>> ### Whats new
>> - Now colors are saved with the XML as well
>> - Colors are kept when changing to a different graph
>> - The user can remove the color again: This uses the color from the filter or WHITE otherwise
>
> That works great! Thanks Roberto for fixing that. As discussed offline, we could add a "remove all colors" options in a separate RFE.
> 
> So, the only minor problem left is the "No..." that does not look like a button and therefore is not suggesting to click it. Maybe you find a fix for that. If not, I guess it's okay to move forward with this patch and come back to it later again.

thanks @chhagedorn , @robcasloz and @eme64 for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22440#issuecomment-2508015798