RFR: 8345172: x86: Some CPU feature asserts are declared as 32-bit only [v3]

Damon Fenacci dfenacci at openjdk.org
Fri Nov 29 15:37:37 UTC 2024


On Fri, 29 Nov 2024 15:17:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Noticed this while cleaning up the 32-bit x86 code. We baseline our 64-bit x86 to be at least UseSSE=2. Therefore we still need to check for features UseSSE > 2. I have found a few places where we do NOT_LP64 for these checks. I checked other `VMVersion::supports_*()` uses, and I think these are the only two outliers.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wrap more SSE 1/2 asserts in NOT_LP64

Marked as reviewed by dfenacci (Committer).

Cool! Thank you!

-------------

PR Review: https://git.openjdk.org/jdk/pull/22432#pullrequestreview-2470185158
PR Comment: https://git.openjdk.org/jdk/pull/22432#issuecomment-2508040455


More information about the hotspot-compiler-dev mailing list