RFR: 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() [v3]

Roland Westrelin roland at openjdk.org
Wed Oct 2 07:13:51 UTC 2024


On Tue, 1 Oct 2024 23:35:42 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - comment
>>  - Merge branch 'master' into JDK-8340824
>>  - more
>>  - more
>>  - single memory area
>>  - Revert "type interfaces footprint"
>>    
>>    This reverts commit 43e2e91c6aaf029e62760e641e207d9d17a3a943.
>>  - type interfaces footprint
>>  - Revert "fix"
>>    
>>    This reverts commit 3598dc08625269aa0a6ecff2a6903c4217b801ee.
>>  - fix
>
> Looks good.
> 
> It feels a bit weird to see `GrowableArray` used to represent a read-only data structure, but I understand that you still benefit from some helper methods it provides.

@iwanowww @merykitty thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21163#issuecomment-2387773938


More information about the hotspot-compiler-dev mailing list