RFR: 8328528: C2 should optimize long-typed parallel iv in an int counted loop [v19]

Kangcheng Xu kxu at openjdk.org
Thu Oct 3 16:47:44 UTC 2024


On Wed, 2 Oct 2024 11:27:08 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update comments in TestParallelIvInIntCountedLoop.java
>
> test/hotspot/jtreg/compiler/loopopts/parallel_iv/TestParallelIvInIntCountedLoop.java line 325:
> 
>> 323: 
>> 324:         for (int i : iterations) {
>> 325:             Asserts.assertEQ(i, testIntCountedLoopWithIntIV(i));
> 
> Code in this loop is not guaranteed to be even C2 compiled because IR verification will be executed in a separate VM. IR framework tests that also want to verify the output, should be written like this:
> 
> https://github.com/openjdk/jdk/blob/9bd478593cc92a716151d1373f3426f1d92143bb/test/hotspot/jtreg/testlibrary_tests/ir_framework/examples/CustomRunTestExample.java#L84-L97

Updated to use custom run methods instead. Thanks for the info!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18489#discussion_r1786536420


More information about the hotspot-compiler-dev mailing list