RFR: 8341622: Tag-specific disabled default decorators for UnifiedLogging [v2]
Antón Seoane
duke at openjdk.org
Mon Oct 7 11:46:19 UTC 2024
On Mon, 7 Oct 2024 11:17:18 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Antón Seoane has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review changes
>
> src/hotspot/share/logging/logSelectionList.cpp line 62:
>
>> 60: }
>> 61: }
>> 62: return LogDecorators(0);
>
> Here I'd like to see either an explanation of 0 as `LogDecorators(0 /* comment */)` or a meaningful name.
I have used the mask_from_decorators function, I think it should be cleaner now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21383#discussion_r1790064483
More information about the hotspot-compiler-dev
mailing list