RFR: 8325495: C2: implement optimization for series of Add of unique value [v8]

[Kangcheng Xu]

On Mon, 7 Oct 2024 07:28:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update comments, use explicit opcode comparisons for LShift nodes
>
> src/hotspot/share/opto/addnode.cpp line 446:
> 
>> 444: }
>> 445: 
>> 446: // Match `a << CON`, extract `a` and `1 << CON`
> 
> "extract" was a bit confusing at first. So, what you mean is return `a` and set `multiplier` to `1 << CON`. Maybe you want to update the comment to make this more explicit? Maybe something like that:
> 
> // Try to match `a << CON`. On success, return `a` and set `1 << CON` as `multiplier`.
> 
> You could do the same for the other `find*` methods.

Updated comments. Thanks for the suggestion!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20754#discussion_r1790709000