RFR: 8341784: Refactor TypeVect to use a BasicType instead of a const Type*

Vladimir Kozlov kvn at openjdk.org
Tue Oct 8 23:07:58 UTC 2024


On Tue, 8 Oct 2024 19:46:12 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> This patch refactors `TypeVect` to use a `BasicType` instead of a `const Type*` as our current implementation. This conveys the element information in a clearer and safer manner.
> 
> Please take a look and leave your reviews,
> Thanks a lot.

Looks reasonable. Need to test it internally.

src/hotspot/share/opto/type.cpp line 2531:

> 2529: 
> 2530: //------------------------------meet-------------------------------------------
> 2531: // Compute the MEET of two types. It returns a new Type object.

It never returns new type now.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21414#pullrequestreview-2355671466
PR Review Comment: https://git.openjdk.org/jdk/pull/21414#discussion_r1792593799


More information about the hotspot-compiler-dev mailing list