RFR: 8325495: C2: implement optimization for series of Add of unique value [v9]

Kangcheng Xu kxu at openjdk.org
Wed Oct 9 02:52:38 UTC 2024


On Tue, 8 Oct 2024 15:48:55 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Testing looked good.

Thank you @chhagedorn. Could please grant an approval once again (after updates only to comments) so we can merge this? Thanks!

> test/hotspot/jtreg/compiler/c2/TestSerialAdditions.java line 65:
> 
>> 63:             "mulAndAddToZero", //
>> 64:             "mulAndAddToMinus1", //
>> 65:             "mulAndAddToMinus42" //
> 
> Why did you add the trailing `//`?

Those are added to prevent formatter from collapsing these lines to one. I've gone ahead to remove them.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20754#issuecomment-2401163656
PR Review Comment: https://git.openjdk.org/jdk/pull/20754#discussion_r1792714150


More information about the hotspot-compiler-dev mailing list