RFR: 8340141: C1: rework ciMethod::equals following 8338471 [v2]
Dean Long
dlong at openjdk.org
Thu Oct 10 21:46:14 UTC 2024
On Wed, 9 Oct 2024 21:17:46 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>>
>> simplification based on reviewer comments
>
> src/hotspot/share/ci/ciMethod.cpp line 692:
>
>> 690:
>> 691: // Redefinition support.
>> 692: if (this->get_Method()->is_old() || root_m->get_Method()->is_old()) {
>
> Is it safe to access raw `Method*` from a compiler thread which is not in VM state?
No, probably not. I'll fix it. I was assuming the whole function was in the VM state.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21148#discussion_r1796131749
More information about the hotspot-compiler-dev
mailing list